Skip to content

fix(random_test_runner): remove workaround, fixed in https://github.c…#1604

Open
esteve wants to merge 1 commit intotier4:masterfrom
esteve:remove-tinxyml2-workaround
Open

fix(random_test_runner): remove workaround, fixed in https://github.c…#1604
esteve wants to merge 1 commit intotier4:masterfrom
esteve:remove-tinxyml2-workaround

Conversation

@esteve
Copy link
Copy Markdown

@esteve esteve commented May 22, 2025 •
edited
Loading

Description

This PR removes the workaround for autowarefoundation/autoware_universe#10410

Abstract

The tinyxml2_vendor package is unable to find the TinyXML2 library, potential fix can be found at ros2/tinyxml2_vendor#23

@esteve
Copy link
Copy Markdown
Author

esteve commented May 22, 2025

Do not merge until ros2/tinyxml2_vendor#23 is merged and backported to Humble

@HansRobo
Copy link
Copy Markdown
Member

HansRobo commented May 23, 2025

@esteve
Thank you for this pull-request!
Ok, I'll wait ros2/tinyxml2_vendor#23 to be merged.

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label May 23, 2025
@HansRobo HansRobo mentioned this pull request May 23, 2025
Merged
@HansRobo
Copy link
Copy Markdown
Member

HansRobo commented Nov 13, 2025

Now, ros2/tinyxml2_vendor#23 was already merged.
I will work to merge this.

@esteve esteve force-pushed the remove-tinxyml2-workaround branch from b10f098 to 92814c3 Compare November 13, 2025 08:19
@esteve esteve mentioned this pull request Nov 13, 2025
Open
3 tasks
@HansRobo
Copy link
Copy Markdown
Member

HansRobo commented Nov 14, 2025

Oh, the CIs are failed.
The fix was not backported to humble?

@esteve
Copy link
Copy Markdown
Author

esteve commented Nov 14, 2025

@HansRobo it's only available for rolling, I'll submit PRs to humble, jazzy and humble

@esteve
Copy link
Copy Markdown
Author

esteve commented Nov 14, 2025

@HansRobo I've submitted the following PRs backporting the fix for Humble (ros2/tinyxml2_vendor#27), Jazzy (ros2/tinyxml2_vendor#28) and Kilted (ros2/tinyxml2_vendor#29)

@HansRobo
Copy link
Copy Markdown
Member

HansRobo commented Nov 15, 2025

@esteve Thank you very much!
After the "sync" including the humble PR, we can merge this pull-request.

@esteve esteve force-pushed the remove-tinxyml2-workaround branch 2 times, most recently from 1694a2d to c6007ec Compare November 25, 2025 16:17
@esteve
Copy link
Copy Markdown
Author

esteve commented Nov 25, 2025

@HansRobo ros2/tinyxml2_vendor#27 and ros2/tinyxml2_vendor#28 are merged and released, this PR can be merged now

@esteve esteve force-pushed the remove-tinxyml2-workaround branch from 0a61f43 to 9d12d7f Compare November 27, 2025 10:00
@HansRobo
Copy link
Copy Markdown
Member

HansRobo commented Nov 28, 2025

Hmm, perhaps ros2/tinyxml2_vendor#27 wasn't enough.
Under certain conditions, TINYXML_LIBRARY_LIST_LENGTH can become 0, and this case seems to occur with scenario_simulator_v2.

@f0reachARR f0reachARR mentioned this pull request Jan 8, 2026
Closed
@f0reachARR f0reachARR mentioned this pull request Jan 20, 2026
Open
@esteve @mitsudome-r
fix(random_test_runner): remove workaround, fixed in ros2/tinyxml2_ve…
3d1e8ce 
…ndor#23

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the remove-tinxyml2-workaround branch from 9d12d7f to 3d1e8ce Compare April 1, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakuturu583 hakuturu583 Awaiting requested review from hakuturu583 hakuturu583 is a code owner

@yamacir-kit yamacir-kit Awaiting requested review from yamacir-kit yamacir-kit is a code owner

@HansRobo HansRobo Awaiting requested review from HansRobo HansRobo is a code owner

@shouth shouth Awaiting requested review from shouth shouth is a code owner

@takanotaiga takanotaiga Awaiting requested review from takanotaiga takanotaiga is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bump patch If this pull request merged, bump patch version of the scenario_simulator_v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@esteve @HansRobo